[Max] Bug: IAnimatable.GetGuid() extension function incorrectly reassigns Guid

[Selmar]

Hi,

I've just found a bug.. well, I guess ... not really?

The problem is, I think, a guid conflict or something sneakier. There is one node that is exported, however, when calling maxNode.GetGuid() for retrieving the guid of the node, the node gets assigned a new guid.

This expression in this function is false: guids[uid].Equals(node as IInterfaceServer

            if (uidData != null)
            {
                uid = new Guid(uidData.Data);

                if (guids.ContainsKey(uid))
                {
                    // If the uid is already used by another node
                    if (guids[uid].Equals(node as IInterfaceServer) == false)
                    {
                        // Create a new uid for current node
                        uid = CreateGuid(node);
                    }
                }
                else
                {
                    guids.Add(uid, node);
                }
            }

However, this is really strange, because the node exists in the list of nodes with this guid. Maybe you have seen something similar before? I'm still investigating. If I can isolate the issue I might send you the .max file.

[Selmar]

Okay, so in fact it looks like the CreateGuid function does not correctly overwrite the data in the AppDataChunk, because every time this is called, the same guid is returned (which is a conflicting value): var uidData = node.GetAppDataChunk(Loader.Class_ID, SClass_ID.Basenode, 0);

As a result, it creats a new guid for this node every time GetGuid is called.

        private static Guid CreateGuid(this IAnimatable node)
        {
            Guid uid = Guid.NewGuid();
            guids.Add(uid, node);
            node.AddAppDataChunk(Loader.Class_ID, SClass_ID.Basenode, 0, uid.ToByteArray());
            return uid;
        }

[kcoley]

@Selmar thanks for the PR!