Skin hierarchy #1026
Merged
Skin hierarchy #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the skeleton hierarchy to see if any ancestor has the skin as children. The goal is to choose which transformation matrix to apply at the root of the skeleton (World or Local).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add search down hierarchy to identify the presence of the skinned mesh and consequently select different Transformation matrix for the skeleton root (World, Local or Identity).
Before this only World and Identity were considered.
For BabylonJS, the Skeleton root cannot share a common ancestor with the mesh it own the skin, otherwize, the transformation is applied twice.
Therefore, Max is highly permissive regarding this point and allow ANY mesh to be a bone or part of the hierachy.
This PR fix this particular case.