Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test case for GH#332. #335

Merged
merged 2 commits into from
Mar 9, 2018
Merged

Failing test case for GH#332. #335

merged 2 commits into from
Mar 9, 2018

Conversation

rwjblue
Copy link
Collaborator

@rwjblue rwjblue commented Mar 8, 2018 •
edited
Loading

Before the fixing commit, the CI build fails with:

not ok 5 Chrome 62.0 - tests/autorun: autorun interleaved with microtasks do not get dropped [GH#332]
    ---
        actual: >
            first,second,third
        expected: >
            first,second,third,fourth
        stack: >
                at http://localhost:7357/2539/named-amd/tests.js:98:16
        Log: |
    ...

After the fix is 🍏

Fixes #332

@rwjblue
Avoid pausing queues when queues are completed.
b593407 
Prior to this commit, we would cause one extra autorun after all queues
were flushed but we would _not_ check to see if all queues were empty
again therefore dropping any tasks scheduled.
@krisselden krisselden merged commit 37ffe2a into BackburnerJS:master Mar 9, 2018
@rwjblue rwjblue deleted the autorun-race branch March 9, 2018 00:58
@rwjblue rwjblue mentioned this pull request Mar 9, 2018
Closed
@rwjblue
Copy link
Collaborator Author

rwjblue commented Mar 17, 2018

FYI - This fix was not sufficient, #336 has more details on failure scenarios...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microtask update introduced event dropping
2 participants
@rwjblue @krisselden