This repository has been archived by the owner on Aug 24, 2019. It is now read-only.
Sonar 6 fix for Faux Pas #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 7, 2017 11:02
Issuable is created even if the inputFile is null Check if inputFile is null before continuing execution
Added extra null check
|
Hi, |
|
Hi guys, can you please merge this issues + do release ? |
|
Thanks a lot @macostea ! I merged it, and will release it soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issuable is created even if the inputFile is null
Check if inputFile is null before continuing execution
Fixes issue #19
This happens for example if we have a file with a whitespace in the path. There should be a better way to handle these files though.
In the previous version they were ignored as well.