Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shift JIS support #160

Closed
wants to merge 20 commits into from
Closed

Fix Shift JIS support #160

wants to merge 20 commits into from

Conversation

askdkc
Copy link
Contributor

@askdkc askdkc commented Mar 18, 2024

This PR is a fix for the issue #123

williamdes and others added 19 commits December 7, 2022 11:41
Debian adjustments and project improvements
Co-authored-by: Christopher Georg <christopher.georg@sr-travel.de>
allow PHPUnit 10/11,
allow "spatie/phpunit-snapshot-assertions" 5
…action

chore: bump github action "codecov/codecov-action" 3 => 4
* Non-locale aware of scale and translate
* Fix lint warning - too long line
@askdkc
Copy link
Contributor Author

askdkc commented Mar 18, 2024

@DASPRiD

I have no idea which part is causing the Lint error (no logs it seems).
If you can show me where to fix, I'm happy to do that.

@DASPRiD
Copy link
Member

DASPRiD commented Mar 19, 2024

@askdkc There are logs, it's about non-required use of double quotes instead of single quotes, click on the details.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 68.29268% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 63.28%. Comparing base (3c6b551) to head (ec210b9).
Report is 13 commits behind head on master.

Files Patch % Lines
src/Encoder/Encoder.php 77.77% 2 Missing ⚠️
src/Renderer/Image/SvgImageBackEnd.php 0.00% 2 Missing ⚠️
src/Common/BitArray.php 66.66% 1 Missing ⚠️
src/Renderer/Color/Alpha.php 0.00% 1 Missing ⚠️
src/Renderer/Color/Cmyk.php 0.00% 1 Missing ⚠️
src/Renderer/Eye/CompositeEye.php 0.00% 1 Missing ⚠️
src/Renderer/Module/DotsModule.php 0.00% 1 Missing ⚠️
src/Renderer/Module/RoundnessModule.php 0.00% 1 Missing ⚠️
src/Renderer/Path/Curve.php 0.00% 1 Missing ⚠️
src/Renderer/Path/EllipticArc.php 0.00% 1 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #160      +/-   ##
============================================
+ Coverage     62.88%   63.28%   +0.39%     
  Complexity      934      934              
============================================
  Files            47       47              
  Lines          2727     2974     +247     
============================================
+ Hits           1715     1882     +167     
- Misses         1012     1092      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@askdkc
Copy link
Contributor Author

askdkc commented Mar 19, 2024

@DASPRiD

Thanks! I fixed the lint errors.

@DASPRiD
Copy link
Member

DASPRiD commented Mar 19, 2024

Whoops, you might have to rebase against the main branch again, I'm sorry, doing some maintenance.

@DASPRiD DASPRiD deleted the branch Bacon:master March 19, 2024 00:32
@DASPRiD DASPRiD closed this Mar 19, 2024
@askdkc
Copy link
Contributor Author

askdkc commented Mar 19, 2024

@DASPRiD

OK, I will recreated my PR as #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet