feature: initial bsc vault implementations #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethkaneki
approved these changes
Mar 9, 2021
| public provider = new ethers.providers.JsonRpcProvider(Provider.Binance); | ||
| } | ||
|
|
||
| export const eth = new Ethereum(); |
There was a problem hiding this comment.
Should these live within modules or services?
There was a problem hiding this comment.
this will be multi module, we can talk about what to do with this. i'll make an issue for these
| @@ -42,4 +43,8 @@ export const MERKLE_CLAIM_BUCKET = process.env.MERKLE_CLAIM_BUCKET || 'MISSING R | |||
| // third party api constants | |||
| export const CURVE_API_URL = 'https://www.curve.fi/raw-stats/apys.json'; | |||
| export const COINGECKO_URL = 'https://api.coingecko.com/api/v3/simple'; | |||
| export const ETHERS_JSONRPC_PROVIDER = new ethers.providers.JsonRpcProvider('https://cloudflare-eth.com/'); | |||
|
|
|||
| export enum Provider { | |||
There was a problem hiding this comment.
I think this should be moved to a config service at some point. Doesn't need to be in this PR, but just writing it down.
This was referenced Mar 9, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.