Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting univ3 methods and add script to min lowest range #100

Merged
merged 17 commits into from
Feb 10, 2022
Merged

Porting univ3 methods and add script to min lowest range #100

merged 17 commits into from
Feb 10, 2022

Conversation

petrovska-petro
Copy link
Collaborator

@petrovska-petro petrovska-petro commented Feb 3, 2022 •
edited
Loading

Tackles #32

Command:

brownie run  scripts/issue/32/mint_lowest_range_uni_v3

@petrovska-petro petrovska-petro marked this pull request as draft February 3, 2022 19:29
@petrovska-petro
Copy link
Collaborator Author

petrovska-petro commented Feb 4, 2022 •
edited
Loading

Reminder: thinking to add another wd method, which i think it can allow to go directly from crvIbBTC to wbtc. Avoiding the slippage discrepancy on 2nd wd action.

ref: https://etherscan.io/tx/0x4a6cf6cfba40ccefd7428e30f567d46ad6d4df7f3cfbf4a09a95bd8be9d82584

@petrovska-petro
Copy link
Collaborator Author

Thru zapper seems to behave well, avoiding slippage issue:

Snap locally:

snapshot result for 0x042B32Ac6b453485e357938bdC38e0340d4b9276:
                         balance_before         balance_after           balance_delta
symbol                                                                               
bibbtc/sbtcCRV-f  25.000000000000000000  0.000000000000000000  -25.000000000000000000
WBTC               0.046680780000000000  5.560590170000000000    5.513909390000000000

@petrovska-petro petrovska-petro marked this pull request as ready for review February 9, 2022 16:34
@petrovska-petro petrovska-petro requested a review from a team February 9, 2022 16:35
gosuto-inzasheru
gosuto-inzasheru reviewed Feb 9, 2022
View reviewed changes
Copy link
Collaborator

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so many uni v3 guns!

just found one (old) reference to v3pool_wbtc_badger.

great_ape_safe/ape_api/uni_v3.py Outdated Show resolved Hide resolved
jalbrekt85
jalbrekt85 reviewed Feb 9, 2022
View reviewed changes
Copy link
Contributor

@jalbrekt85 jalbrekt85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zapper method if very helpful. I added a suggestion for getting _get_n_coins to work with v2. Also this method seems to duplicated on L76 and 104

great_ape_safe/ape_api/curve.py Outdated Show resolved Hide resolved
@gosuto-inzasheru gosuto-inzasheru mentioned this pull request Feb 10, 2022
Closed
jalbrekt85
jalbrekt85 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@jalbrekt85 jalbrekt85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jalbrekt85 jalbrekt85 mentioned this pull request Feb 10, 2022
Merged
@petrovska-petro petrovska-petro merged commit 3955b70 into main Feb 10, 2022
@petrovska-petro petrovska-petro deleted the issue32 branch February 10, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosuto-inzasheru gosuto-inzasheru gosuto-inzasheru approved these changes

@jalbrekt85 jalbrekt85 jalbrekt85 approved these changes

@Tritium-VLK Tritium-VLK Awaiting requested review from Tritium-VLK

@sajanrajdev sajanrajdev Awaiting requested review from sajanrajdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petrovska-petro @gosuto-inzasheru @jalbrekt85