-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting univ3 methods and add script to min lowest range #100
Conversation
Reminder: thinking to add another wd method, which i think it can allow to go directly from ref: https://etherscan.io/tx/0x4a6cf6cfba40ccefd7428e30f567d46ad6d4df7f3cfbf4a09a95bd8be9d82584 |
Thru zapper seems to behave well, avoiding slippage issue: Snap locally:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so many uni v3 guns!
just found one (old) reference to v3pool_wbtc_badger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zapper method if very helpful. I added a suggestion for getting _get_n_coins
to work with v2. Also this method seems to duplicated on L76 and 104
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Tackles #32
Command: