Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callouts sent to a TestResultUrl/Slack/etc should be run in a separate thread #67

Closed
Badgerati opened this issue Mar 5, 2017 · 2 comments
Assignees
Milestone

Comments

@Badgerati
Copy link
Owner

Badgerati commented Mar 5, 2017

Currently when a test finishes and we have the result, the result is synchronously sent out to the TestResultUrl or Slack if they're configured.

These callouts should be done asynchronously, so as to now impact main test running performance.

The callouts for the "test run started" and "test run ended" will still be synchronous, as data is required back from them.

Furthermore, Edison should be able to wait for a results to be sent; should the tests finish running and a couple of results are still being sent out.

Also, if a callout to an endpoint fails 5 times, no more callouts should be sent to that URL - this is to stop pointless callouts and to prevent 60sec timeouts.

@Badgerati
Copy link
Owner Author

Applied a bit of load balancing for runs that have many many test results. There will be two parallel tasks working together sending the results.

@Badgerati
Copy link
Owner Author

Merged into Epic branch

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant