-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drops HttpListener, and rewrites Pode's listener in .NET Core. #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
As per #573, the HttpListener has been dropped. This also rewrites Pode's socket listener using .NET Core. Everything that Pode's listener supported before is still present, plus the following new features that previously only worked if using HttpListener:
-SelfSigned
onAdd-PodeEndpoint
now works - and is xplat-CertificateThumbprint
onAdd-PodeEndpoint
now works - but only on Windows-CertificateName
(previously just-Certificate
) onAdd-PodeEndpoint
now works - but also only on WindowsThe following have also been renamed:
-CertificateFile
is now-Certificate
onAdd-PodeEndpoint
-RawCertificate
is now-X509Certificate
onAdd-PodeEndpoint
The
-Type Pode
onStart-PodeServer
is no longer needed/present - as there's now only 1 listener.Related Issue
Resolves #573