Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : users listing - admin badge for Group admins #64

Merged
merged 5 commits into from
Feb 26, 2021

Conversation

deelanM
Copy link
Collaborator

@deelanM deelanM commented Feb 26, 2021

image

@deelanM deelanM linked an issue Feb 26, 2021 that may be closed by this pull request
4 tasks
@deelanM deelanM removed a link to an issue Feb 26, 2021
4 tasks
@deelanM deelanM linked an issue Feb 26, 2021 that may be closed by this pull request
4 tasks
@@ -26,6 +26,7 @@ export default {
tableHeaders() {
return [
{ text: this.$t('users.email'), align: `left`, value: `email` },
{ text: '', value: `role` },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a simple string inside backticks? This is confusing

@@ -102,6 +103,13 @@ export default {
<template v-slot:item.email="{ item }">
<nuxt-link :to="`/users/${item.id}`">{{ item.email }}</nuxt-link>
</template>
<template v-slot:item.role="{ item }">
<v-badge
v-if="item.role === 'company_admin'"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use constant, please...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@deelanM deelanM merged commit a3e1228 into develop Feb 26, 2021
@Jessy-BAER Jessy-BAER deleted the feat-admin-badge branch March 9, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group : users listing rework
2 participants