Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarity in page-break file names #5

Closed
aleemb opened this issue Mar 2, 2017 · 1 comment
Closed

Clarity in page-break file names #5

aleemb opened this issue Mar 2, 2017 · 1 comment

Comments

@aleemb
Copy link

aleemb commented Mar 2, 2017

It would be far clearer if you simply renamed the classes to page-break-before and page-break-after. No explanation needed here.
@aleemb aleemb changed the title Clarify in page-break file names Clarity in page-break file names Mar 2, 2017
@BafS
Copy link
Owner

BafS commented Mar 2, 2017

You are right, I will do that for the next release, thank you.

BafS added a commit that referenced this issue Mar 2, 2017
@BafS
Add .page-break-before for clarity (#5)
922de62 
Update docs
@BafS BafS closed this as completed Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aleemb @BafS