Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add mimic smartvault v2 #219

Merged
merged 2 commits into from Mar 6, 2024
Merged

Conversation

gosuto-inzasheru
Copy link
Member

No description provided.

@Xeonus
Copy link
Contributor

Xeonus commented Mar 4, 2024

@gosuto-inzasheru: according to Mimic this should be smart vault v3, not v2.

So to clarify from my understanding:

  • Smartvault v2: 0x94dd9c6152a2a0bbcb52d3297b723a6f01d5f9f7 (we just called it smartvault unti now AFAIK, see this proposal)
  • Smartvault v3: 0x9e5d6427d2cdadc68870197b099c2df535ec3c97

@gosuto-inzasheru
Copy link
Member Author

gosuto-inzasheru commented Mar 4, 2024

@Xeonus i didnt want to introduce breaking changes renaming "smartvault" to "smartVaultV2", so only did so for the v3

see f46cc2c

Copy link
Member

@Tritium-VLK Tritium-VLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leave the v2 address in there too.

@gosuto-inzasheru
Copy link
Member Author

can you elaborate on the changes needed @Tritium-VLK, it is not making any sense to me

@Tritium-VLK
Copy link
Member

It wouldn't hurt to rename all the other mimic stulff (claimer/bpt swapper/etc) as v2 as well, but this is good enough for now. We can think about that more later.

@Tritium-VLK Tritium-VLK merged commit 2f5d9ac into main Mar 6, 2024
2 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the chore/mimic_smartvault_v2 branch March 20, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants