Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP-552: Authorize Mimic Smart Vaults V3 on Arbitrum, Polygon and Gnosis #820

Merged
merged 2 commits into from Mar 4, 2024
Merged

BIP-552: Authorize Mimic Smart Vaults V3 on Arbitrum, Polygon and Gnosis #820

merged 2 commits into from Mar 4, 2024

Conversation

Xeonus
Copy link
Collaborator

@Xeonus Xeonus commented Feb 28, 2024

  • enable Mimic's smart vault v3 on Arbitrum, Polygon and Gnosis chains

@Xeonus
BIP-552: Authorize Mimic Smart Vaults V3 on Arbitrum, Polygon and Gnosis
4b19b0b 
- enable Mimic's smart vault v3 on Arbitrum, Polygon and Gnosis chains
@github-actions GitHub Actions
Copy link
Contributor

BIP validation results for file BIPs/2024-W10/BIP-552-ARB.json:
Commit: 4b19b0bad18440fb5c291da36a7e3295b6c51847

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2024-W10/BIP-552-GNOSIS.json:
Commit: 4b19b0bad18440fb5c291da36a7e3295b6c51847

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2024-W10/BIP-552-POLY.json:
Commit: 4b19b0bad18440fb5c291da36a7e3295b6c51847

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions GitHub Actions
Copy link
Contributor

FILENAME: BIPs/2024-W10/BIP-552-ARB.json
MULTISIG: multisigs/dao (arbitrum:0xaF23DC5983230E9eEAf93280e312e57539D098D0)
COMMIT: 4b19b0bad18440fb5c291da36a7e3295b6c51847
CHAIN(S): arbitrum
TENDERLY: SUCCESS

+----------------------+---------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+------------+
| function             | caller_name   | caller_address                             | fx_paths                                                                                                   | action_ids                                                         | bip     |   tx_index |
+======================+===============+============================================+============================================================================================================+====================================================================+=========+============+
| Authorizer/grantRole | !!NOT FOUND!! | 0x9e5D6427D2cdaDC68870197b099C2Df535Ec3c97 | 20220517-protocol-fee-withdrawer/ProtocolFeesWithdrawer/withdrawCollectedFees(address[],uint256[],address) | 0x93b1b7dba9fb074b573d5edb3c983e0490a00925f709289485f0c75988e100cf | BIP-552 |          0 |
+----------------------+---------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+------------+

FILENAME: BIPs/2024-W10/BIP-552-GNOSIS.json
MULTISIG: multisigs/dao (gnosis:0x2a5AEcE0bb9EfFD7608213AE1745873385515c18)
COMMIT: 4b19b0bad18440fb5c291da36a7e3295b6c51847
CHAIN(S): gnosis
TENDERLY: SUCCESS

+----------------------+---------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+------------+
| function             | caller_name   | caller_address                             | fx_paths                                                                                                   | action_ids                                                         | bip     |   tx_index |
+======================+===============+============================================+============================================================================================================+====================================================================+=========+============+
| Authorizer/grantRole | !!NOT FOUND!! | 0x9e5D6427D2cdaDC68870197b099C2Df535Ec3c97 | 20220517-protocol-fee-withdrawer/ProtocolFeesWithdrawer/withdrawCollectedFees(address[],uint256[],address) | 0xf6c9a5b5acca77f76aed5abd6f810c52c3ff5f4a8a40ee9e1bc09f85795e73da | BIP-552 |          0 |
+----------------------+---------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+------------+

FILENAME: BIPs/2024-W10/BIP-552-POLY.json
MULTISIG: multisigs/dao (polygon:0xeE071f4B516F69a1603dA393CdE8e76C40E5Be85)
COMMIT: 4b19b0bad18440fb5c291da36a7e3295b6c51847
CHAIN(S): polygon
TENDERLY: SUCCESS

+----------------------+---------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+------------+
| function             | caller_name   | caller_address                             | fx_paths                                                                                                   | action_ids                                                         | bip     |   tx_index |
+======================+===============+============================================+============================================================================================================+====================================================================+=========+============+
| Authorizer/grantRole | !!NOT FOUND!! | 0x9e5D6427D2cdaDC68870197b099C2Df535Ec3c97 | 20220517-protocol-fee-withdrawer/ProtocolFeesWithdrawer/withdrawCollectedFees(address[],uint256[],address) | 0x25995e0bfb9b837ed9e3ed24df7d42689be47c45073cc1953bb0836b292faa13 | BIP-552 |          0 |
+----------------------+---------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+------------+

@Xeonus
Copy link
Collaborator Author

Xeonus commented Feb 28, 2024 •
edited

Please carefully cross-check action IDs. Also confirm that target 0x9e5d6427d2cdadc68870197b099c2df535ec3c97 is correctly set everywhere (same for all chains). See BIP-488 for a similar proposal to compare against. Mimic smart vault target is the same.

@gosuto-inzasheru
Copy link
Member

adding these addresses to the address book here: BalancerMaxis/bal_addresses#219

gosuto-inzasheru
gosuto-inzasheru approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cross refd action ids with bal deployments repo, eg https://github.com/balancer/balancer-deployments/blob/8df6e330a561a2f176dc12ed619159c7ff456f87/action-ids/arbitrum/action-ids.json

@Xeonus Xeonus merged commit c593f35 into main Mar 4, 2024
@Xeonus Xeonus deleted the BIP-552-enable-mimic-smart-vault-v3-arbi-poly-gnosis branch March 4, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosuto-inzasheru gosuto-inzasheru gosuto-inzasheru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xeonus @gosuto-inzasheru