Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal configuration seems ignored #9

Closed
Baldhor opened this issue Aug 7, 2023 · 6 comments
Closed

Decimal configuration seems ignored #9

Baldhor opened this issue Aug 7, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@Baldhor
Copy link
Owner

Baldhor commented Aug 7, 2023

          Not sure if related, but the amount of decimal places seems to be ignored entirely?

According to the log on my ESPHome/slimmelezer it is reporting these values with these decimals of accuracy:

13:47:53	[D]	[sensor:093]	'Power Consumed Phase 1': Sending state 0.48100 kW with 3 decimals of accuracy
13:47:53	[D]	[sensor:093]	'Energy Consumed Tariff 1': Sending state 3375.22803 kWh with 3 decimals of accuracy
13:47:53	[D]	[sensor:093]	'Energy Consumed Tariff 2': Sending state 3789.25708 kWh with 3 decimals of accuracy

However, in the Homey web app (in the browser) there are less decimals:
image
(Only 2 instead of the 3 it should display?)

And the iPhone app is even more confused:
image
(I'm not even going to count the amount of decimals there)

I have nothing specific set in the ESPHome config about the decimals; This is how I set the device up on the Homey:
image

(The screenshots and the log snippet were taken at different moments, therefore the actual values don't match)

Originally posted by @aedens78 in #4 (comment)

@Baldhor Baldhor self-assigned this Aug 7, 2023
@Baldhor Baldhor added the bug Something isn't working label Aug 7, 2023
@Baldhor
Copy link
Owner Author

Baldhor commented Aug 7, 2023

@aedens78 fixed in master
image

@Baldhor
Copy link
Owner Author

Baldhor commented Aug 7, 2023

I will try to fix this before publishing
image

Not related, but found it while fixing decimals

as for the little story, homey was expecting a number (integer), but the code used to set a string ...

Baldhor added a commit that referenced this issue Aug 7, 2023
Changelog: Fixed issues #8, #9 and #10. Also include a fix to console.re to avoid stackcall overflow
@Baldhor
Copy link
Owner Author

Baldhor commented Aug 7, 2023

Version 0.3.4 published, awaiting certification
https://homey.app/fr-fr/app/nl.inversion.esphome/ESPhome/test/

@Baldhor Baldhor closed this as completed Aug 7, 2023
@Baldhor
Copy link
Owner Author

Baldhor commented Aug 8, 2023

@aedens78 it is published. Can you confirm it is fixed?

@aedens78
Copy link

aedens78 commented Aug 8, 2023

@Baldhor Yes! Looks to be fixed; both the webclient and the iPhone app now show the configured decimals!
(I did remove the device, remove and reinstall the app, and re-added the device to force the update, and now all is well)

image
image

Thank you very much for the fast support and the fix! :)

@Baldhor
Copy link
Owner Author

Baldhor commented Aug 8, 2023

(I did remove the device, remove and reinstall the app, and re-added the device to force the update, and now all is well)
Yeah it would be cool to update capabilities options on reconnection. Re pairing the device break existing flows ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants