Feature/linking speaker twitter #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bedded tweets webview
|
I am merging all the PRs in order to make an iOS build and test everything, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
WebViewin the speaker detail screen, and replaces it with a twitter icon in the header that can be tapped to be brought to the speaker's twitter profile.The icon appears only if the speaker actually has a twitter handle.
The implementation leverages the
LinkingAPI to openhttps://twitter.com/${speaker.twitter}.On Android, both the browser and the native twitter apps can handle such links, and the user can specify with which app to handle the linking (tested).
Testing on the iOS simulator opens the twitter profile in Safari. I am not sure what would happen if there was the native Twitter app installed. @BalestraPatrick, could you check?
If it opens the browser anyway, we could modify profile links on iOS to use the
twitter://schema.This PR closes #17 and #12.