Update appveyor.yml #1057
Merged
Update appveyor.yml #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
+ Coverage 83.88% 84.14% +0.26%
==========================================
Files 165 165
Lines 15739 15739
==========================================
+ Hits 13203 13244 +41
+ Misses 2536 2495 -41
Continue to review full report at Codecov.
|
jmthomas
commented
Oct 10, 2019
| @@ -9,7 +9,6 @@ rvm: | |||
| - 2.6.3 | |||
| - 2.5.6 | |||
| - 2.4.6 | |||
| - 2.3.8 | |||
There was a problem hiding this comment.
This is officially deprecated by Ruby so while it doesn't mean we don't support it I don't want it to be part of the Travis builds
jmthomas
commented
Oct 10, 2019
| @@ -114,7 +114,7 @@ spec = Gem::Specification.new do |s| | |||
| s.add_development_dependency 'simplecov', '~> 0.15' | |||
| s.add_development_dependency 'codecov', '~> 0.1' | |||
| s.add_development_dependency 'benchmark-ips', '~> 2.0' | |||
| s.add_development_dependency 'ruby-prof', '~> 0.16' if RUBY_ENGINE == 'ruby' # MRI Only | |||
| s.add_development_dependency 'ruby-prof', '~> 1.0' if RUBY_ENGINE == 'ruby' # MRI Only | |||
There was a problem hiding this comment.
1.0 only supports Ruby 2.4 or higher
jmthomas
commented
Oct 10, 2019
|
|
||
| cache: | ||
| # If one of the files after the right arrow changes, cache will be invalidated | ||
| - vendor\bundle -> appveyor.yml, Gemfile, cosmos.gemspec |
There was a problem hiding this comment.
Hopefully this will make the appveyor builds faster
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1056