Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop if testcase and abort checked #1068

Merged
merged 3 commits into from
Nov 23, 2019
Merged

Stop if testcase and abort checked #1068

merged 3 commits into from
Nov 23, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2019

closes #1036

@ghost ghost self-requested a review October 28, 2019 19:53
@ghost
Copy link
Author

ghost commented Oct 28, 2019

While this was a fairly easy fix it makes me wonder if there are other cases we're not covering. Like what if there is an exception during setup or teardown?

@ghost
Copy link

ghost commented Nov 18, 2019

Exceptions during setup/teardown should also abort - good catch

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also abort on setup/teardown exceptions

@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #1068 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1068      +/-   ##
==========================================
+ Coverage   84.15%   84.19%   +0.03%     
==========================================
  Files         165      165              
  Lines       15746    15892     +146     
==========================================
+ Hits        13251    13380     +129     
- Misses       2495     2512      +17
Impacted Files Coverage Δ
lib/cosmos/utilities/ruby_lex_utils.rb 90.78% <0%> (-1.81%) ⬇️
lib/cosmos/packets/packet_config.rb 98.41% <0%> (-0.61%) ⬇️
lib/cosmos/packets/structure_item.rb 91.98% <0%> (-0.52%) ⬇️
lib/cosmos/interfaces/protocols/length_protocol.rb 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c8d3a...2bd9275. Read the comment docs.

Also fix earlier setup and teardown to support abort_on_exception
@jmthomas jmthomas merged commit cc16402 into master Nov 23, 2019
@jmthomas jmthomas deleted the stop_on_exception branch November 23, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestRunner: ABORT_TESTING_AFTER_ERROR ignored for test cases added individually to testsuite
3 participants