Add combo_box prompt #163 #164
Conversation
|
The way we implemented message_box was with a Qt::MessageBox class. It only supports horizontal buttons so adding vertical buttons would require constructing an entirely different box with a vertical layout. That's not so bad but what should the API look like? The current api is message_box(titile, *buttons). I don't want to break the existing API and the splat is eating all the parameters. I could just add a new method vertical_message_box(title, *buttons). Thoughts? |
|
new method vertical_message_box |
|
I spent some time making them look similar to the Qt::MessageBox with white message over a standard grey background. Then I did some refactoring to helper methods which I renamed to underscores so they won't be accidentally used. As I was doing this I wondered about adding scroll to hold many buttons or supporting a grid layout but I figure the combo_box can handle those use cases. |
|
Looks good. 👍 |
Merge in COSMOSEE/base from fortify_ruby to master * commit '018cd1fc4ce7673f3f7a86414b4788acb78e6e5c': Fix Ruby fortify warnings Fix remaining platform issues
No description provided.