re #479 Update Limits Monitor to differentiate between ignoring stale… #500
Conversation
… packets and ignoring out-of-limits items. Also rework the GUI a little bit so full item names are displayed, and provide the option to ignore items or packets for out-of-limits items.
|
@ryanatball @jasonatball Guys, I modified limits monitor quite a bit with this change, see if you like the changes before I start wrenching on the AHK stuff. Big changes:
|
|
Looks good so far. Can you add timestamps to the log messages on the Log tab? |
|
Looks good however I noticed that the text color in the value box appears to be one second (one refresh period) slower than the bar moving and the overall state. Has this always been like this? |
|
@ryanatball Yup, sure thing. @jasonatball Yeah, I didn't mess with the rate for the thread that updates the values. I can, though. |
| index = @stale.delete_item(item) | ||
| widget = @items.delete("#{target_name} #{packet_name}") if index | ||
| @remove_item_callback.call(widget) if widget | ||
| # TBD get all out-of-limits items for the packet that is no longer stale. |
There was a problem hiding this comment.
I'm not sure this TBD is necessary. Won't the CmdTlmServer notify you of everything that is out of limits?
There was a problem hiding this comment.
Yes it will-- that comment is wrong and I'll make it go away.
…lation of labelvaluelimitsbar widget, and remove deprecated comment.
|
@ryanatball @jasonatball Ok, I've addressed all comments and the AHK is updated. I think this should be ready for final review. |
|
Looks like it's working well. 👍 |
|
👍 |
… packets and ignoring out-of-limits items. Also rework the GUI a little bit so full item names are displayed, and provide the option to ignore items or packets for out-of-limits items.