Buffer file spec #648
Merged
Buffer file spec #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
closes #649 |
ghost
commented
Nov 14, 2017
| @@ -120,7 +120,6 @@ def initialize | |||
| 'stop_raw_logging_router', | |||
| 'get_server_message_log_filename', | |||
| 'start_new_server_message_log'] | |||
| @mutex = Mutex.new | |||
There was a problem hiding this comment.
This mutex causes "no _dump_data is defined for class Thread::Mutex" errors when the CTS starts. I think it's because I declare it last and it's getting passed back (by default) somewhere when we're trying to Marshall everything and calculate the MD5 sum. In any case I've already seen the JRuby test fail even with this "fix" so I'm removing it.
Codecov Report
@@ Coverage Diff @@
## master #648 +/- ##
=========================================
Coverage ? 81.11%
=========================================
Files ? 150
Lines ? 13658
Branches ? 0
=========================================
Hits ? 11079
Misses ? 2579
Partials ? 0
Continue to review full report at Codecov.
|
2 similar comments
|
👍 |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.