Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Journalcrawler and Journal event handling #27

Closed
3 tasks
Balvald opened this issue Dec 29, 2022 · 8 comments
Closed
3 tasks

[Refactor] Journalcrawler and Journal event handling #27

Balvald opened this issue Dec 29, 2022 · 8 comments
Assignees
Labels
Milestone

Comments

@Balvald
Copy link
Owner

Balvald commented Dec 29, 2022

Theres probably still quite the amount of duplicated code since the original event handling was just a full copypaste of the journalcrawling code, (ew I know.)

To amend this:

  • Identify duplications
  • Create helper functions
  • Use those helper functions to replace these duplications.

Helper functions will be stored in the eventhandling.py and will be imported into respective files once thats finished.

@Balvald Balvald self-assigned this Dec 29, 2022
@Balvald
Copy link
Owner Author

Balvald commented Jan 2, 2023

soon™

@Balvald
Copy link
Owner Author

Balvald commented Jan 2, 2023

I've decided to not do this one in the next release because, This one will probably need as much work if not more than what update v0.2.2 encompasses.

@Balvald Balvald added this to the v0.2.5 milestone Jan 7, 2023
@Balvald
Copy link
Owner Author

Balvald commented Jan 8, 2023

ugh not sure if this stays in v0.2.5....

@Balvald
Copy link
Owner Author

Balvald commented Jan 8, 2023

nah it'll have to wait for another version since latest release still hasn't its bugfix #35.

Wan't to prioritize a better functioning next release than one where I get around and need like a whole week just working on this besides haven't started with it yet ....

@Balvald Balvald modified the milestones: v0.2.5, v0.2.6 Jan 8, 2023
@Balvald
Copy link
Owner Author

Balvald commented Feb 14, 2023

on hold for investigations concerning #45

soon™

@Balvald
Copy link
Owner Author

Balvald commented Mar 7, 2023

initial description changed as it changed slightly through finishing #41 #42 and #43

@Balvald Balvald modified the milestones: v0.2.7, Testing Mar 8, 2023
@Balvald
Copy link
Owner Author

Balvald commented Aug 18, 2023

#27 (comment) comes to haunt me again

Reason: #48

@Balvald
Copy link
Owner Author

Balvald commented Aug 20, 2023

Note: I evidently already did some refactoring for event handling.

@Balvald Balvald closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant