Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] in progress scan value (on the "Last Exobiology Scan:" line) always shows N/A now #35

Closed
Tracked by #39
slippycheeze opened this issue Jan 7, 2023 · 2 comments · Fixed by #40
Closed
Tracked by #39

[BUG] in progress scan value (on the "Last Exobiology Scan:" line) always shows N/A now #35

slippycheeze opened this issue Jan 7, 2023 · 2 comments · Fixed by #40
Assignees
@Balvald
Labels
bug Something isn't working
Milestone
v0.2.5

Comments

@slippycheeze
Copy link
Contributor

slippycheeze commented Jan 7, 2023 •
edited
Loading

Describe the bug
Since updating to the latest, 0.2.4, release the in-progress scans only show "N/A" value. The accumulation of Unsold Scan Value does happen as expected.

To Reproduce
Steps to reproduce the behavior:

  1. Enable in-progress scan value, if it isn't.
  2. Scan something.

Screenshots

cough I thought I had a 1/3 scan there, but this is 3/3. anyway, the "N/A" is present all through the scan process.

image

Desktop (please complete the following information):

  • OS: windows
  • AST Version: 0.2.4
  • EDMC Version: 5.7.0

Additional context
Have verified that finishing a scan, and starting a new one, on another planet, wasn't going to kick-start the process.
@slippycheeze slippycheeze added the bug Something isn't working label Jan 7, 2023
@Balvald Balvald self-assigned this Jan 7, 2023
@Balvald Balvald added this to the v0.2.5 milestone Jan 7, 2023
Balvald referenced this issue Jan 7, 2023
@Balvald
Update load.py
4276c39 
code where I get the value of the plant to be displayed is wrong.

I instead have to try and in the case of the plantname regardless because I call this function "update_last_scan_plant." in on_preferences_closed. with the old name which may be not a proper plant name.

the previous change here was because I tried to fix this functions behaviour after using the reset button. Said previous change instead made it so that every call of the update_last_scan_plant function call without an argument was equal to using the reset button just before. for the worth of the plant.
@slippycheeze
Copy link
Contributor Author

I can confirm that this change to load.py fixes the bug on my side, when manually applied.
Thank you so much for the fast response, and the plugin.

@Balvald Balvald mentioned this issue Jan 8, 2023
Closed
@Balvald
Copy link
Owner

Balvald commented Jan 8, 2023

yay c:

Though I thought with me forgetting little things that bug me afterwards.
I think it'll be high time to open another repo to write and store tests so that I don't accidentially make things worse at some point.

This was referenced Jan 8, 2023
Closed
Open
Balvald added a commit that referenced this issue Jan 8, 2023
@Balvald
Update load.py
bb4d47b 
this should implement something that'll fix #37

also again redo the fix for #35 because I unknowingly removed the commit with the
SHA: 4276c39
out of the repos history while rebasing.
So it's changes are again found in here.
@Balvald Balvald mentioned this issue Jan 8, 2023
Merged
Balvald added a commit that referenced this issue Jan 8, 2023
@Balvald
Update load.py
8e3b401 
this should implement something that'll fix #37

also again redo the fix for #35 because I unknowingly removed the commit with the
SHA: 4276c39
out of the repos history while rebasing.
So it's changes are again found in here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Balvald Balvald

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.5
Development

Successfully merging a pull request may close this issue.

Pull bugfixes for #35 and #37 onto main Balvald/ArtemisScannerTracker
2 participants
@slippycheeze @Balvald