-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] show "Scans on this Planet" as well as "Scans in this System" #36
Comments
What I have locally all the time (and technically already have locally) is the amount for each planet. that just needs to be displayed differently once we end up in the vicinity of a planet. (gotta remind myself if to check status.json again) The information I do not have locally all the time would be the max amount of plant species. Otherwise a way thats completely detached from edmc-canonn and any of their resources would be to prompt the user to use the dss and save it locally if and only if theres biosignals (otherwise not relevant to the plugin). But definitly another feature to add to the journalcrawler aswell. That way it could go through everything check the dss scans and retroactively create the user's database of "known" but unscanned biosignals and by extension the progress the CMDR made on it. Atleast if I remember correctly what info is part of the detailed scans in the journals (could be that the info for max number is in there but not the species, would still be better than nothing) |
"event":"SAASignalsFound" is the event that holds the info of max bioscans for each planet. it happens after a DSS scan of the planet. |
after triggering that event for a planet it doesn't appear again when using the dss scanner. |
first test implementation for #36 removed functions that have been moved. to their own files
on planet info #36 shows the right numbers now. ui still looks very meh. gotta build the display as a string and just add it after the number for scans in this system.
Small changes to the ui for #36 hopefully it looks nice. Hopefuilly it works as intended. Added a debug tickbox. - if on on various places the plugin will report all sorts of things to the edmc debug log, will have to expand what it reports soon aswell. - removing ignore tags in the code for too high cognitive complexity
first test implementation for #36 removed functions that have been moved. to their own files
on planet info #36 shows the right numbers now. ui still looks very meh. gotta build the display as a string and just add it after the number for scans in this system.
Small changes to the ui for #36 hopefully it looks nice. Hopefuilly it works as intended. Added a debug tickbox. - if on on various places the plugin will report all sorts of things to the edmc debug log, will have to expand what it reports soon aswell. - removing ignore tags in the code for too high cognitive complexity
Is your feature request related to a problem? Please describe.
Sometimes I lose track in my head of where I am on scanning a planet; I know it has five bio signals, but I can't remember if I have scanned all of them or not. (eg: I exited the game on a planet after scanning, went to sleep, work, and then next evening have no idea where exactly I was at.)
Right now I open up the "Scans in this System", then mentally cross-reference the number of recorded scans for the planet I'm on and the number of bio signals found on the planet. Works, but is mental effort.
Describe the solution you'd like
![annotated image of the UI component showing where I imagine the display showing](https://user-images.githubusercontent.com/306753/211196915-9bc8f418-5a2a-49cd-b2db-a6460ad241bc.png)
Show "on this planet:" as well as "in this system:" in the summary line for scans:
In the illustration I show "1/3" scans on the planet; I'd love if this kept track of the number of biological signals on the planet and showed progress like that.
Simply showing the count "for the current planet" when that context exists would be super useful alone, though.
Describe alternatives you've considered
I actually get some of this feedback from the EDMC-Canonn plugin, which tracks the total number of biological signals for the current planet (if you open that part of the UI) and if I have personally hit them with the comp-scanner.
Sadly, there is a big difference between "comp-scanned" and "took three successful bio samples", meaning it sometimes falls down because (a) I comp-scan something to record the location, since it is hard to find and I'm in the middle of sampling another bio type, or (b) I comp-scan something, but don't actually sample it, or (c) I sample something, and completely forget to comp-scan any of the three locations.
Additional context
I considered making a separate feature request for remembering the number of biological signals on the planet and/or asking spansh/EDSM about it. I didn't think it was worth it, but if you want I'll split it off.
I'd like it if the "on this planet" and "on this system" indicators went green, or showed a nice ticked box, when they were fully sampled, too. Something to say "job done, time to go
homeon to the next system."PS: thank you again for the wonderful tool. I am extremely happy to have it, and it is one of the most frequently used tools in my EDMC stack.
The text was updated successfully, but these errors were encountered: