pull state for v0.2.7 to main #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summed over all cmdrs in the journalcrawler which would end up with unexpected behaviour when using several cmdrs with the plugin where all unsold value of all cmdrs at the point of running the journalcrawler would be assigned to a single cmdr unsure if this is what prompted it to misbehave #48 though assuming the bug that prompted #48 happens for someone with just a single account with odyssey this wouldn't be it.
Implemented ask_canonn_nicely to get info about SAAsignals after having them found already.
initializing AST_testvar with data retrieved from canonn. Adding newly found signals to AST_testvar (I'll need to rename it before I release with this new feature.)
moving ui and saving loading cmdr specific data into their own files.
first test implementation for #36 removed functions that have been moved. to their own files
preventing error when asking canonn moving ui elements around
preventing key errors when looking up elements numbers that have been determined are wrong right now.
on planet info #36 shows the right numbers now. ui still looks very meh. gotta build the display as a string and just add it after the number for scans in this system.
moved rest of ui to corresponding ui file. forcing most logger prints to when plugin.debug is True (Need a tickbox so that the user can switch it at their will)
Small changes to the ui for #36 hopefully it looks nice. Hopefuilly it works as intended. Added a debug tickbox. - if on on various places the plugin will report all sorts of things to the edmc debug log, will have to expand what it reports soon aswell. - removing ignore tags in the code for too high cognitive complexity
- proper padding for newest ui element. "on this body: x/y" - removed outdated and unused prices form update 14. - removed unecessary calls to the canonn api in on_load() and in journal_entry() - removed unecessary cast to bool when interacting with AST_debug - removed old debug variable as it is unused now. - fixed comments of functions in AST.py still assuming the class is in load.py
- Had the plugin sometimes forgetting to hide the "On this body" display for some reason. That seems fixed now. - Now using the AST_debug variable properly (forgot some get statements) - removed filename string to be used in the creation of AST object. (variable would only get assigned and then not used from then on.)
When we try to use a planet name as a key it can of course be that said planet has no bio signals in this case it is not present in AST_bios_on_planet. Need to catch the KeyError and let it continue without spamming the debug log, unless we want it to spam the debug log.
Added that: when near a planet the corresponding name of a already finished species gets shown in green if that species was already scanned or sold For this I had to modify the following behaviour: Upon leaving a body we set the current body to an empty string: "" instead of leaving the outdated info of the current body displayed.
Source? Unknown as of yet Hasn't surfaced just again. Trying to hunt it down through more debug map.
appears I only get like every second ScanOrganic event o.o
changed nothing significant. Plugin gets every entry. only real change is that in between now and then I restarted the Computer.
feeling a bit dumb now. Atleast this slipped into a release.
We now set the current body only in dashboard updates.
adding some logging so I can start to see why it does not want to enter the codeblock below the added logging calls.
added some explanations of new features for v0.2.7 added new screenshots.
added things not explained in the readme that are shown in the preference ui picture.
removed mentioning of old version in the readme. Added the tag "new" in front fo things that are new in 0.2.7 restructured things for item no. 8 on the main ui
prepare for next release
This was
linked to
issues
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug that would combine the unsold values of all cmdrs when using multiple Commanders.
Added feature [Feature] show "Scans on this Planet" as well as "Scans in this System" #36
Some restructuring to not overload my brain with a single file that contains all the code that could break. (With subsequent fixing of bugs introduced during that process.)