Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when building 0.13 release under Linux #28

Closed
freq-mod opened this issue Dec 15, 2018 · 11 comments
Closed

Problem when building 0.13 release under Linux #28

freq-mod opened this issue Dec 15, 2018 · 11 comments

Comments

@freq-mod
Copy link
Contributor

gui/mainwindow.cpp: In member function ‘void MainWindow::on_instrumentListWidget_customContextMenuRequested(const QPoint&)’: gui/mainwindow.cpp:944:8: error: ‘class QAction’ has no member named ‘setShortcutVisibleInContextMenu’; did you mean ‘setShortcutContext’? edit->setShortcutVisibleInContextMenu(true); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ setShortcutContext [...] Makefile:1639: recipe for target 'mainwindow.o' failed make: *** [mainwindow.o] Error 1

make produces lots of warnings related to mainwindow.cpp and one error above. OS is Ubuntu 18.04 LTS, all dependecies installed, I think.

@rerrahkr
Copy link
Member

Thanks for your report.
Before Qt 5.10, setShortcutVisibleInContextMenu seems unnecessary. I will fix it.

@OPNA2608
Copy link
Member

OPNA2608 commented Dec 15, 2018

NixOS 18.09 here, can't confirm - make succeeds without any errors for me. Qt 5.11.1 installed.

Can you double-check that you have the required dependencies installed and followed the installation instructions correctly?
https://github.com/rerrahkr/BambooTracker#build-on-linux

@rerrahkr
Copy link
Member

Since I use Qt 5.10.1 for development, it should not be a problem when building with later version.

@freq-mod
Copy link
Contributor Author

@OPNA2608:
build-essential is already the newest version (12.4ubuntu1).
libqt5multimedia5-plugins is already the newest version (5.9.5-0ubuntu1).
qt5-default is already the newest version (5.9.5+dfsg-0ubuntu1).
qtmultimedia5-dev is already the newest version (5.9.5-0ubuntu1).
qmake seems to create the stash file correctly, make dies when dealing with mainwindow.cpp, like I wrote in the original post.

@OPNA2608
Copy link
Member

qt5-default is already the newest version (5.9.5+dfsg-0ubuntu1).

I use Qt 5.10.1 for development

This property was introduced with Qt 5.10 apparently.

I'm afraid you'll either have to:
· update Ubuntu to 18.10 to get Qt 5.11 via qt5-default
· wait until the property gets removed/replaced with a compatible alternative:
Before Qt 5.10, setShortcutVisibleInContextMenu seems unnecessary. I will fix it.
· manually compile Qt5, Qt5 Multimedia and Qt5 Multimedia Plugins which is not recommended, to say the least or
· use a different Distribution with a more up-to-date version of Qt5

@freq-mod
Copy link
Contributor Author

Thanks for the info. I will just upgrade to 18.10 then...

@alexmyczko
Copy link
Contributor

alexmyczko commented Dec 15, 2018

I'll create an official debian package for this! http://sid.ethz.ch/debian/bambootracker/
we'll need to write a wnpp bug (RFP/ITP)

@OPNA2608
Copy link
Member

OPNA2608 commented Dec 15, 2018

I have a working Nix package, but I'll wait until we get a proper v1 or at least v0.2 release before submitting it to the nixpkgs repo.

(that is off-topic though. i suggest opening a seperate issue about it)

OPNA2608 added a commit to OPNA2608/BambooTracker that referenced this issue Dec 17, 2018
Updates the README.md to specify Ubuntu 18.10 as the minimum version and explain why 18.04 is currently unsupported. ( though this is being worked on, see BambooTracker#28 )
@rerrahkr
Copy link
Member

I fixed it 8c3f2b7

@trebmuh
Copy link
Contributor

trebmuh commented Dec 27, 2018

If that can be of any help, a fresh build from 99b9ed3 is building on a Debian stable (aka "Stretch"). I launched it and the main GUI appeared. I didn't get further than that so far.

@freq-mod
Copy link
Contributor Author

OK looks like it was fixed and can be build even on stable Debian. Closing then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants