Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build breaks in Paka, HamletAst and SockeyeInstantiator #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satnam6502
Copy link

@satnam6502 satnam6502 commented Jun 25, 2019

When attempting to execute the command:

$ ../hake/hake.sh -s ../ -a x86_64

from the install instructions I got several build breaks due to the Haskell code no longer working with a recent version of GHC. I made changes to hide the Prelude version of <> and also to change a pattern match to avoid falling foul of the new automatic pattern match failure handing (see transitional monad we could try to use instead which would be better than the evasive approach I take in this patch).

Developer's Certificate of Origin 1.1

    By making a contribution to this project, I certify that:

    (a) The contribution was created in whole or in part by me and I
        have the right to submit it under the open source license
        indicated in the file; or

    (b) The contribution is based upon previous work that, to the best
        of my knowledge, is covered under an appropriate open source
        license and I have the right under that license to submit that
        work with modifications, whether created in whole or in part
        by me, under the same open source license (unless I am
        permitted to submit under a different license), as indicated
        in the file; or

    (c) The contribution was provided directly to me by some other
        person who certified (a), (b) or (c) and I have not modified
        it.

    (d) I understand and agree that this project and the contribution
        are public and that a record of the contribution (including all
        personal information I submit with it, including my sign-off) is
        maintained indefinitely and may be redistributed consistent with
        this project or the open source license(s) involved.

    Signed-off-by: Satnam Singh <satnam@google.com>

@barrelfish-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants