Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reversed the way options are browsed inside fzf. #15

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

PranavPeshwe
Copy link
Contributor

@PranavPeshwe PranavPeshwe commented Sep 21, 2023

Currently, cursor movement in the left pane is bottom-to-top, while movement in the right pane is top-to-bottom. It seemed a bit odd hence introduced this change.

Current: https://asciinema.org/a/Q1t5M5BhMo6n83vTps65lYkhx

After layout reversal: https://asciinema.org/a/AELf8GNNg9v4dJBl5lfzzJt8F

Perhaps, we can introduce an env var to control this.

@PranavPeshwe
Copy link
Contributor Author

@BartSte Request review.

@BartSte
Copy link
Owner

BartSte commented Sep 21, 2023

Good catch. I had --reverse configured in my FZF_DEFAULT_OPTS but we should make it the default. There is no need to ad another environment variable as this can also be configured using FZF_HELP_OPTS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants