Skip to content

Commit

Permalink
Don't fail on TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
BasPH committed Apr 5, 2019
1 parent d2f93c8 commit 672177d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ disable=print-statement,
exception-escape,
comprehension-escape,
bad-continuation, # https://github.com/PyCQA/pylint/issues/289
duplicate-code
duplicate-code,
fixme

# Enable the message, report, category or checker with the given id(s). You can
# either give multiple identifier separated by comma (,) or put this option
Expand Down
2 changes: 1 addition & 1 deletion src/pylint_airflow/checkers/dag.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def _find_dag(
if keyword.arg == "dag_id" and isinstance(keyword.value, astroid.Const):
return str(keyword.value.value), call_node

if len(call_node.args) > 0:
if call_node.args:
# TODO support dag_ids set in other ways than constant.
return call_node.args[0].value, call_node

Expand Down

0 comments on commit 672177d

Please sign in to comment.