Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xamarin.Forms] Implementing IsPlaying #206

Merged
merged 4 commits into from
Jun 23, 2019

Conversation

jimbobbennett
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Fixes #205

⤵️ What is the current behavior?

The IsPlaying property in the Xamarin.Forms AnimationView wasn't doing anything

🆕 What is the new behavior (if this is a feature change)?

The IsPlaying property is correctly wired up in the renderer. This also marks AutoPlay as obsolete as it replicates the behaviour of IsPlaying="true"

💥 Does this PR introduce a breaking change?

🐛 Recommendations for testing

The Example.Forms sample project has been updated.

📝 Links to relevant issues/docs

#205

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated
  • Rebased onto current develop

@jimbobbennett
Copy link
Contributor Author

This is a work in progress, the code should work but I can't get the example project to build to test it.

Copy link
Member

@martijn00 martijn00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimbobbennett I've merged some stuff and done changes to get the Forms samples compiling again. Can you rebase your PR and check it?

@afk013
Copy link

afk013 commented Jun 19, 2019

Hi @jimbobbennett could you, when you get a moment rebase the PR please. I have been using your changes for a while now in a locally generated nuget however it would be nice to resume using the public one again especially when bringing Lottie into new projects. Thanks.

@martijn00 martijn00 merged commit 13d2568 into Baseflow:develop Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Xamarin Forms] IsPlaying doesn't do anything
3 participants