Make sure you cannot run multiple permission requests at the same time #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijn00
approved these changes
Aug 13, 2018
mvanbeusekom
deleted the
feature/ios_handle_simultanious_permissionrequests
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix
On iOS it is possible to run multiple requests for permissions at the same time. This doesn't match with the Android API
🆕 What is the new behavior (if this is a feature change)?
The plugin will throw an exception when you send a second request for permissions while the first request is not yet finished.
💥 Does this PR introduce a breaking change?
Nope
🐛 Recommendations for testing
Run example app
📝 Links to relevant issues/docs
🤔 Checklist before submitting