Simplify multiple path support in go plugin

[cornfeedhobo]

This PR seeks to simplify the wrapped pathmunge logic setup in #1267.
Tests have been updated to account for cases with spaces in $PATH.

[cornfeedhobo]

Not sure why the tests failed yet; they pass locally.

[cornfeedhobo]

The output is swallowed when run on travis; not sure how to debug.
Running the tests locally on a linux laptop passes fine

test/run test/plugins/go.plugin.bats
 ✓ plugins go: single entry in GOPATH
 ✓ plugins go: single entry in GOPATH, with space
 ✓ plugins go: single entry in GOPATH, with escaped space
 ✓ plugins go: multiple entries in GOPATH
 ✓ plugins go: multiple entries in GOPATH, with space
 ✓ plugins go: multiple entries in GOPATH, with escaped space

6 tests, 0 failures

Any suggestions?

[cornfeedhobo]

@nwinkler As you can see, I've tried a bunch of stupid stuff to explore travis and try to make it happy, but I'm completely stumped at this point. the tests pass locally, and they pass on osx. Would you please take a look and tell me what you think?

[nwinkler]

Hi, sorry that you have to go through that amount of pain... I was on vacation for the last two weeks.

I'll take a look at this in the next couple of days, trying to replicate the issue. I'm running macOS as well, will try a VM for the Linux stuff...

[cornfeedhobo]

What's crazy is that the CI says macOS works, and I can say from my testing and experience it works on linux (what I dev on most days). I looked at the ruby plugin tests, but I don't see a meaningful difference in how we are verifying PATH.

[nwinkler]

Sorry, haven't had time to look into this yet - life got in the way...

[cornfeedhobo]

No sweat. That's pretty much my entire last year.

[cornfeedhobo]

@nwinkler TRAVIS FINALLY FIXED THE ISSUE AND THE BUILD PASSES. YAAAY!!!
Please, for the love of cthulhu, squash merge this disaster of a commit history.

[nwinkler]

Woohoo!!!!! Thanks for the patience!

(Sorry about the delay, work and life got in the way the last couple of weeks...)

[cornfeedhobo]

Likewise! Thanks for your patience as well.