Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds last segment prompt char to powerline default theme #1449

Merged
merged 2 commits into from
Dec 30, 2019

Conversation

davidpfarrell
Copy link
Contributor

@davidpfarrell davidpfarrell commented Nov 6, 2019

This PR adds the ability to have a multi-character prompt where part of the prompt shares a background color with the last segment. i.e

before
before

after
after

I'm not completely sold on the name of the variable. I would prefer a name that was more related just to the prompt and less to the segment, but couldn't think of a better name. Happy to discuss alternatives.

The feature is only added to the main theme - The Plain theme doesn't have a prompt char, and the Multi-line and Naked themes can just set the existing prompt char since there's no change in background color to try to account for. In fact, this PR explicitly disables the feature for Naked (as it uses the same prompt building method as default) since the result isn't that great.

-DF

[edit updated after picture to reflect changes made to color logic]

@nwinkler
Copy link
Member

This one seems to be next, can you please rebase? (Thanks for the patience!)

@davidpfarrell
Copy link
Contributor Author

davidpfarrell commented Dec 30, 2019

This one seems to be next, can you please rebase? (Thanks for the patience!)

Done ! Also thank you very much for your patience.

ALSO :

Do see the notes in the description above re "not sold on the name of the variable" - Happy to discuss alternatives.

Also, for tracking purposes:

  1. Makes all powerline vars configurable #1448 "Makes all powerline vars configurable"
  2. Fixes prompt bg color on powerline naked theme #1450 "Fixes prompt bg color on powerline naked theme"
  3. Adds SHORT_USER/HOSTNAME support to powerline themes #1446 "Adds SHORT_USER/HOSTNAME support to powerline themes"
  4. Adds shlvl segment to powerline themes #1443 "Adds shlvl segment to powerline themes"
  5. Adds dirstack segment to powerline themes #1442 "Adds dirstack segment to powerline themes"
  6. Adds history + command line number to powerline themes #1444 "Adds history + command line number to powerline themes"
  7. Adds soft-separator support to powerline main + multiline themes #1445 "Adds soft-separator support to powerline main + multiline themes"
  8. Adds last segment prompt char to powerline default theme #1449 "Adds last segment prompt char to powerline default theme"
  9. Adds compact support to powerline themes #1447 "Adds compact support to powerline themes"

@nwinkler nwinkler merged commit 65358aa into Bash-it:master Dec 30, 2019
@nwinkler
Copy link
Member

Thanks - the variable name looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants