Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong function name call in helpers.bash #2058

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

souhaiebtar
Copy link
Contributor

@souhaiebtar souhaiebtar commented Jan 22, 2022

when i tried to install, i got a message _bash-it-pluralize-component command not found; after checking utilities.bash the correct function name was _bash-it-component-pluralize

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

when i tried to install, i got a message `_bash-it-pluralize-component` command not found; after checking `utilities.bash` the correct function name was `_bash-it-component-pluralize`
@gaelicWizard
Copy link
Contributor

gaelicWizard commented Jan 22, 2022

This was my fault from a recent PR. The full updates to lib/helpers is not yet merged.

EDIT: seems like I should spend more time on the testing to prevent silly mistakes like this in the future.

Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the correct name is _bash-it-component-pluralize

Thanks for the PR!

@souhaiebtar souhaiebtar reopened this Jan 25, 2022
@gaelicWizard
Copy link
Contributor

gaelicWizard commented Jan 25, 2022

EDITED: @souhaiebtar, this definitely hasn't been fixed despite the merge of my fixes to lib/helpers, so I'm going to see about setting up some tests to catch this kind of thing in the future. Please rebase on current master and we'll merge!

@NoahGorny, would you be so kind as to expedite this one to cover my oversight? 😃

@gaelicWizard
Copy link
Contributor

Turns out my draft PR #2031 was already catching this! But alsö so many other errors, that I hadn't noticed it as a pre-existing issue! Anyway, tests should cover this when #2031 is done and merged. 😃

@NoahGorny NoahGorny merged commit 60c1000 into Bash-it:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants