Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint errors in multiple files #2192

Merged
merged 5 commits into from
Feb 22, 2023
Merged

Fix lint errors in multiple files #2192

merged 5 commits into from
Feb 22, 2023

Conversation

tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented Feb 10, 2023

Description

There are some shellcheck errors, this PR fixes these

Screenshot_20230210_185009

Motivation and Context

N/A

How Has This Been Tested?

Locally, on linux

Screenshots (if appropriate):

Screenshot_20230210_190427

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

davidpfarrell
davidpfarrell suggested changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on, will save me some time this weekend as I was planning to do the same :)

I have a recommended change. see comments.

install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
davidpfarrell
davidpfarrell reviewed Feb 10, 2023
View reviewed changes
install.sh Outdated Show resolved Hide resolved
davidpfarrell
davidpfarrell approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does it, thanks !

@tbhaxor
Copy link
Contributor Author

tbhaxor commented Feb 22, 2023

@davidpfarrell @NoahGorny can we merge it then?

@davidpfarrell davidpfarrell merged commit 78f8840 into Bash-it:master Feb 22, 2023
@davidpfarrell davidpfarrell mentioned this pull request Feb 22, 2023
Merged
8 tasks
@tbhaxor tbhaxor deleted the fix/lint-errros branch February 22, 2023 17:59
@tbhaxor tbhaxor mentioned this pull request Feb 22, 2023
Open
8 tasks
niontrix pushed a commit to niontrix/bash-it that referenced this pull request May 23, 2023
@tbhaxor
Fix lint errors in multiple files (Bash-it#2192)
64c3be9 
* fix (plugins): enable interpretation of backslash escapes in colors
* fix (lint): disable SC2317 in install.sh
* fix (lint): SC2086 in agnoster theme
* fix (lint): remove exit from install.sh as it is already implemented in the calling function
douglasjacobsen added a commit to douglasjacobsen/bash-it that referenced this pull request Jan 19, 2024
@douglasjacobsen
Merge remote-tracking branch 'upstream/master'
b554ce9 
* upstream/master: (1190 commits)
  Add support to powerline themes to override foreground color (Bash-it#2231)
  ci: Update GitHub actions v2 => v4 (Bash-it#2224)
  docs: Update Bats libraries links (Bash-it#2225)
  fix: bumps go version to 1.21.0 and changes go get to go install
  [terraform] add alias for terraform workspace
  fix (completion): suppress 1091 in brew (Bash-it#2130)
  Allow for longer command min duration (Bash-it#2198)
  Implement yarn completion (Bash-it#2190)
  Fix lint errors in multiple files (Bash-it#2192)
  bug: Use C style strings when checking for invalid alias characters (Bash-it#2188)
  Remove libra chat reference
  Add more aliases for `git branch`, use long form
  remove function wrapper around kubectl alias registration
  bug: Use en_US when fetching EPOCHREALTIME
  bug:Install shellcheck wget (Bash-it#2173)
  fix(theme): use correct escape sequence to avoid weird text overwriting
  chore: Use grep -E / grep -F instead of egrep / fgrep (Bash-it#2164)
  Fixed broken code blocks in troubleshooting.rst
  Removed Bash Dependency section from README and added it to troubleshooting.rst
  Update variable name to match projects.plugin.bash
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpfarrell davidpfarrell davidpfarrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tbhaxor @davidpfarrell