Allow for longer command min duration

[OMEGARAZER]

Description

Allows for setting "COMMAND_DURATION_MIN_SECONDS" to more than 60 seconds without adding to the prompt. Previously always showed with lengths over 60 seconds regardless of setting. The documentation does not mention that it would always show when over 1 minute so no change is necessary.

Motivation and Context

Allows setting minimum duration for prompts longer than 60 seconds.

How Has This Been Tested?

Tested locally on Ubuntu 22.04 and Debian 11 using sleep of various lengths.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• If my change requires a change to the documentation, I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
• I have added tests to cover my changes, and all the new and existing tests pass.

[davidpfarrell]

Great Catch ! I suggest a slightly different fix however:

before

	if ((command_duration > 0)); then
		minutes=$((command_duration / 60))
		seconds=$((command_duration % 60))
	fi

	_dynamic_clock_icon "${command_duration}"
	if ((minutes > 0)) && ((command_duration >= COMMAND_DURATION_MIN_SECONDS)); then
		printf "%s %s%dm %ds" "${COMMAND_DURATION_ICON:-}" "${COMMAND_DURATION_COLOR:-}" "$minutes" "$seconds"
	elif ((seconds >= COMMAND_DURATION_MIN_SECONDS)); then
		printf "%s %s%d.%01ds" "${COMMAND_DURATION_ICON:-}" "${COMMAND_DURATION_COLOR:-}" "$seconds" "$deciseconds"
	fi

after

	if ((command_duration >= COMMAND_DURATION_MIN_SECONDS)); then
		minutes=$((command_duration / 60))
		seconds=$((command_duration % 60))

		_dynamic_clock_icon "${command_duration}"
		if ((minutes > 0)); then
			printf "%s %s%dm %ds" "${COMMAND_DURATION_ICON:-}" "${COMMAND_DURATION_COLOR:-}" "$minutes" "$seconds"
		else
			printf "%s %s%d.%01ds" "${COMMAND_DURATION_ICON:-}" "${COMMAND_DURATION_COLOR:-}" "$seconds" "$deciseconds"
		fi
	fi

Essentially bail earlier if the threshold isn't met - It also looks a bit cleaner.

Lemme know what you think and thanks for putting this PR together !

[OMEGARAZER]

You worried me with the before block thinking I duplicated a line by accident.

Your changes make perfect sense though, I will make those changes and update when I get back home in a few hours.

[davidpfarrell]

You worried me with the before block thinking I duplicated a line by accident.

LOL copy-pasta strikes again - I fixed it in after version but forgot to adjust before version -- Edited now for plausible deniability of course :)

[davidpfarrell]

I like it !