Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dilemma workaround: reduce soft serial speed #53

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

burkfers
Copy link
Collaborator

@burkfers burkfers commented Feb 25, 2024

Description

The rp2040 half duplex serial implementation using the vendor driver is flawed. On an otherwise unmodified stock firmware with serial debugging enabled, somewhat frequent failed handshakes can be observed on the Dilemma v2 and Dilemma Max.

Until now, this had no observable effects in general use. The upcoming qmk breaking changes merge contains
qmk#21548, which exacerbates the issue and leads to spurious encoder events being generated, most often direction 0 for encoder 0, meaning a stock Dilemma will randomly scroll up.

Testing has revealed 38400 Bd to be stable with no observable downside on the Dilemma and Dilemma Max.

Credit/Thanks to:

  • Drashna for leading me to the cause of the spurious encoder events I was observing, and linking past discussion on this problem
  • Yingeling for reproducing on more hardware

Types of Changes

  • Core
  • Bugfix (rather: workaround)
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@burkfers burkfers marked this pull request as ready for review February 25, 2024 17:23
@0xcharly 0xcharly merged commit 2d9ef4c into Bastardkb:bkb-master Feb 26, 2024
3 checks passed
@burkfers burkfers deleted the bkb-softserial branch February 26, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants