Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assignable #6

Open
wants to merge 22 commits into
base: mtc_parameters_bart_feats
Choose a base branch
from

Conversation

lachlan-git
Copy link
Collaborator

@lachlan-git lachlan-git commented Aug 2, 2024

Tested and Emmbank now outputs, running a maz and taz assignment with the network today

@lachlan-git lachlan-git marked this pull request as ready for review August 12, 2024 16:56
@i-am-sijia i-am-sijia changed the base branch from develop to mtc_parameters_bart_feats August 13, 2024 17:39
lasso/emme.py Outdated Show resolved Hide resolved
lasso/emme.py Outdated Show resolved Hide resolved
lasso/emme.py Outdated Show resolved Hide resolved
lasso/emme.py Outdated Show resolved Hide resolved
lasso/emme.py Outdated Show resolved Hide resolved
lasso/emme.py Outdated Show resolved Hide resolved
lasso/emme.py Outdated Show resolved Hide resolved
lasso/emme.py Outdated Show resolved Hide resolved
lasso/emme.py Outdated Show resolved Hide resolved
lasso/emme.py Outdated Show resolved Hide resolved
@i-am-sijia
Copy link
Collaborator

A general comment, we try to be explicit in the object name if the object type is a data frame, e.g., instead of using bus_routes, we should use bus_routes_df, same applies for geo data frame, ...

Copy link
Collaborator

@i-am-sijia i-am-sijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both MAZs and TAZs should be included in the network, but only TAZs should be treated as centroids. This is the same logic as before.

lasso/emme.py Outdated Show resolved Hide resolved
lasso/emme.py Outdated Show resolved Hide resolved
lasso/emme.py Outdated Show resolved Hide resolved
lasso/emme.py Outdated Show resolved Hide resolved
lasso/emme.py Show resolved Hide resolved
lasso/emme.py Outdated Show resolved Hide resolved
@lachlan-git lachlan-git self-assigned this Aug 14, 2024
@lachlan-git
Copy link
Collaborator Author

Hold off on merge for 1 minute I need to check something

@lachlan-git
Copy link
Collaborator Author

Note, to regenerate network connectors, this version of Ranch is Required:
wsp-sag/Ranch#16

ranch_roadway = ranch.Roadway(nodes_df, links_df.drop(columns=["index_left", "index_right"], errors="ignore"), shapes_df, ranch_params)
ranch_roadway.build_centroid_connectors(build_taz_active_modes=True, build_maz_drive=True,
input_taz_polygon_file=taz_zone_shapefile_path,
input_maz_polygon_file=maz_zone_shapefile_path,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit concerned about this step. Can we please make sure the TAZ IDs are not renumbered?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised Not Implemented error. Will require reworking in Task Order 6

@lachlan-git
Copy link
Collaborator Author

Validation of current pr (run 22) against run 15. This is linkwise differences in volumes broken down by ft.

image

func_types slopes r_vals
0 1 1.06243 0.996615
1 2 1.04499 0.996582
2 3 1.0325 0.984447
3 4 1.04521 0.988295
4 5 1.03811 0.987906
5 6 1.02264 0.984992

lasso/emme.py Outdated Show resolved Hide resolved
lasso/emme.py Outdated Show resolved Hide resolved
@lachlan-git
Copy link
Collaborator Author

Adressed comments, will require one more rerun, as very minor changes occured

@lachlan-git
Copy link
Collaborator Author

Hold off on merging, very minor changes need to do one more model run

@lachlan-git
Copy link
Collaborator Author

Minor Updates to Code, Checking for major differences in results:

run_number Freeway Expressway Ramp Divided Arterial Undivided Arterial Collector Local Connector Service Road
run 15 old code, emme 4.6.1 3666 3485 6448 39050 58376 95681 407444 387250 12909
run 22 previous version of pr, open paths 3666 3485 6448 39050 58376 95681 407444 567516 12453
run 26 final version of pr, emme 4.6.1 3666 3485 6448 39050 58376 95681 407444 567516 13788

Note small change in Service Roads due to bug discovered in algorithm keeping bus links.

This resulted in a very similar performing network:

base comparison facility_type slopes r_vals rmse base_vmt comparison_vmt
0 run 15 old code, emme 4.6.1 run 26 final version of pr, emme 4.6.1 Freeway 1.06 1 987.51 3.89672e+07 4.0941e+07
1 run 15 old code, emme 4.6.1 run 26 final version of pr, emme 4.6.1 Expressway 1.05 1 435.84 1.74159e+07 1.81646e+07
2 run 15 old code, emme 4.6.1 run 26 final version of pr, emme 4.6.1 Ramp 1.03 0.98 328.61 9.77085e+06 1.01754e+07
3 run 15 old code, emme 4.6.1 run 26 final version of pr, emme 4.6.1 Divided Arterial 1.04 0.99 372.29 8.76985e+07 9.245e+07
4 run 15 old code, emme 4.6.1 run 26 final version of pr, emme 4.6.1 Undivided Arterial 1.04 0.99 234.13 6.91518e+07 7.23458e+07
5 run 15 old code, emme 4.6.1 run 26 final version of pr, emme 4.6.1 Collector 1.02 0.98 139.28 4.30083e+07 4.47094e+07
6 run 22 previous version of pr, open paths run 26 final version of pr, emme 4.6.1 Freeway 1 1 134.51 4.09701e+07 4.0941e+07
7 run 22 previous version of pr, open paths run 26 final version of pr, emme 4.6.1 Expressway 1 1 157.66 1.81244e+07 1.81646e+07
8 run 22 previous version of pr, open paths run 26 final version of pr, emme 4.6.1 Ramp 1 1 115.14 1.0164e+07 1.01754e+07
9 run 22 previous version of pr, open paths run 26 final version of pr, emme 4.6.1 Divided Arterial 1 1 174.9 9.24619e+07 9.245e+07
10 run 22 previous version of pr, open paths run 26 final version of pr, emme 4.6.1 Undivided Arterial 1 1 93.28 7.23738e+07 7.23458e+07
11 run 22 previous version of pr, open paths run 26 final version of pr, emme 4.6.1 Collector 0.99 0.99 81.39 4.46801e+07 4.47094e+07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants