-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove assignable #6
base: mtc_parameters_bart_feats
Are you sure you want to change the base?
Conversation
A general comment, we try to be explicit in the object name if the object type is a data frame, e.g., instead of using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both MAZs and TAZs should be included in the network, but only TAZs should be treated as centroids. This is the same logic as before.
Hold off on merge for 1 minute I need to check something |
Note, to regenerate network connectors, this version of Ranch is Required: |
ranch_roadway = ranch.Roadway(nodes_df, links_df.drop(columns=["index_left", "index_right"], errors="ignore"), shapes_df, ranch_params) | ||
ranch_roadway.build_centroid_connectors(build_taz_active_modes=True, build_maz_drive=True, | ||
input_taz_polygon_file=taz_zone_shapefile_path, | ||
input_maz_polygon_file=maz_zone_shapefile_path, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit concerned about this step. Can we please make sure the TAZ IDs are not renumbered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised Not Implemented error. Will require reworking in Task Order 6
Adressed comments, will require one more rerun, as very minor changes occured |
Hold off on merging, very minor changes need to do one more model run |
Minor Updates to Code, Checking for major differences in results:
Note small change in Service Roads due to bug discovered in algorithm keeping bus links. This resulted in a very similar performing network:
|
Tested and Emmbank now outputs, running a maz and taz assignment with the network today