Limit the depth of the binary numeric expression in Python #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krinart
force-pushed
the
iaroslav/python_bin_num_expr_depth
branch
from
afce3de
to
e01c63d
Compare
krinart
force-pushed
the
iaroslav/python_bin_num_expr_depth
branch
from
e01c63d
to
a7fe5fb
Compare
krinart
force-pushed
the
iaroslav/python_bin_num_expr_depth
branch
from
e1acc4d
to
24770bb
Compare
izeigerman
commented
Feb 6, 2019
|
|
||
| from m2cgen import ast | ||
|
|
||
|
|
||
| class BaseInterpreter: | ||
| class BaseAstInterpreter: |
There was a problem hiding this comment.
I really don't like Ast prefix here. It's kind of obvious what's being interpreted. Same true for AstToCode... why not just CodeGenInterpreter? Or even just ToCodeInterpreter?
izeigerman
commented
Feb 6, 2019
|
|
||
| expected_code = """ | ||
| def score(input): | ||
| var0 = (1) + ((1) + (1)) |
There was a problem hiding this comment.
Can we add a test case where BinExpr are diluted with some other exprs?
Like BinNumExpr -> BinNumExpr -> SubroutineExpr-> BinNumExpr -> IfExpr -> BinNumExpr. Something along those lines.
|
Closed in favor of #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.