Fixed python depth limit; Introduce mixins. #60
Conversation
krinart
changed the base branch from
viktor/expreminets_with_python_depth
to
master
m2cgen/interpreters/interpreter.py
Outdated
| return re.sub("(?!^)([A-Z]+)", r"_\1", name).lower() | ||
|
|
||
|
|
||
| class BaseAstToCodeInterpreter(BaseAstInterpreter): |
There was a problem hiding this comment.
Why do we even need this intermediate entity?
There was a problem hiding this comment.
Otherwise mixins have attribute _cg which they are not aware of what it is.
m2cgen/interpreters/mixins.py
Outdated
| from m2cgen.interpreters.interpreter import BaseAstToCodeInterpreter | ||
|
|
||
|
|
||
| class BinExpressionDepthTrackingMixin(BaseAstToCodeInterpreter): |
There was a problem hiding this comment.
For some reason I thought that mixins supposed to be outside of any particular class hierarchy. This is why they are "mixed in". In our case they are still inheriting the very base class. I'm not sure that it's that important, it just doesn't feel right :)
There was a problem hiding this comment.
Otherwise mixins have attribute _cg which they are not aware of what it is and IDE don't resolve methods of this attribute.
krinart
force-pushed
the
viktor/experiments_with_mixins
branch
2 times, most recently
from
18bae56
to
2566351
Compare
krinart
force-pushed
the
viktor/experiments_with_mixins
branch
from
2566351
to
23c856b
Compare
krinart
changed the title
m2cgen/interpreters/interpreter.py
Outdated
| return re.sub("(?!^)([A-Z]+)", r"_\1", name).lower() | ||
|
|
||
|
|
||
| class BaseAstToCodeInterpreter(BaseInterpreter): |
There was a problem hiding this comment.
Was Ast remained here on purpose? Or did you just miss this one?
m2cgen/interpreters/mixins.py
Outdated
|
|
||
| class BinExpressionDepthTrackingMixin(BaseAstToCodeInterpreter): | ||
| """ | ||
| This mixin provides an ability to call a custom cook when depth of the |
m2cgen/interpreters/mixins.py
Outdated
|
|
||
| It also provides flag `with_linear_algebra` which indicates whether | ||
| linear algebra was used during interpretation. It can be used to add | ||
| dependencies. |
There was a problem hiding this comment.
Maybe add corresponding third party dependencies that provide linear algebra operations and/or data structures?
No description provided.