New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports Polaris' changeling. #12370
Ports Polaris' changeling. #12370
Conversation
Psi Omega you're my heerooo. Seriously though, really appreciate this. The one thing I'm not sure about is firing a gun decloaking ninjas getting mixed in here. It might have had a poll about it a while back though, so I guess it was time. |
verbpath = /mob/proc/changeling_dissonant_shriek | ||
|
||
//A flashy ability, good for crowd control and sewing chaos. | ||
/mob/proc/changeling_resonant_shriek() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest having a cooldown for both this one, and the EMP version, given it's a strong AoE ability.
Other than previous two suggestions (and compile errors which i assume will be fixed soon) this looks great. It might finally make the mode a bit more interesting again. |
Something that'll need testing is changeling rejuvenation/revival as it appears to have been touched by FPB rewrite. |
@@ -113,7 +113,7 @@ | |||
Weaken(10) | |||
else | |||
src.visible_message( | |||
"\red [src] was mildly shocked by the [source].", \ | |||
"\red [src] was mildly shocked by \the [source].", \ | |||
"\red You feel a mild shock course through your body.", \ | |||
"\red You hear a light zapping." \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: <span>
these lines are they've already been touched anyway.
2db3334
to
b085208
Compare
b085208
to
b09fee7
Compare
Any progress on this? Also, we might not want to port the bit about the only way to get evolution points is by killing other changelings, that really reduces the teamwork possible. |
Polaris has made more changeling fixes/changes I need to get around to merge in. |
Conflicts: baystation12.dme code/game/gamemodes/changeling/changeling_powers.dm code/game/gamemodes/changeling/modularchangling.dm
Conflicts: baystation12.dme code/game/gamemodes/changeling/generic_equip_procs.dm code/modules/mob/living/carbon/carbon_defines.dm
Conflicts: baystation12.dme
Conflicts: baystation12.dme code/game/gamemodes/changeling/modularchangling.dm
… less potent, and there is now a three minute cooldown when using Cryostring or Delayed Toxic Sting
Cleans up some comments I forgot to remove.
Conflicts: code/_onclick/item_attack.dm
Conflicts: baystation12.dme code/game/gamemodes/changeling/generic_equip_procs.dm
Round-end report now displays a history of powers the changeling had bought for that round, including resets. Renames purchasedpowers to purchased_powers because I like my underscores. Changelings can always be absorbed by other changelings if the body is husked. Reviving clears the husked status, fixing an exploit where a ling could be husked and alive, and be unabsorbable. A stronger variant of the armblade is available if one also buys recursive enhancement (totaling 5 points). The stronger variant has 30 armor pen, but no additional effects. A stronger varient of the electric hand is available for those who buy recursive enhancement, which does more halloss and costs less chemicals to channel electricity, also costing 5 points. Normal electric hand made a little stronger when using it by grabbing someone, since grabbing is harder. Cryosting description now says it has a cooldown. Delayed toxin sting also now says it has a cooldown. Changes log produced when using finger-lockpick. Endoarmor description made slightly more accurate, for those which may not have a base health of 100. Enfeebling string now reduces a person's health by a percentage, so teshari are not instantly killed by a recursive enhanced version of it. Enfeebling sting now has a 5 minute cooldown as well. Replaces some sleep numbers with X SECONDS/SECOND to make it more clear how long it is. Transforming will wipe your flavor text, instead of keeping your previous identity's flavor text. # Conflicts: # code/game/gamemodes/changeling/modularchangling.dm # code/game/gamemodes/changeling/powers/armblade.dm # code/game/gamemodes/changeling/powers/revive.dm
Armblades can now force depowered or broken airlocks, firelocks, and blast doors, just like a crowbar. Armblades can slash APCs to cut all the wires. Fixing the damage is as simple as mending all the wires. Cleans up the fireaxe wielding check in airlock.dm Removes colon cancer in blast_door.dm Not armblade related: Self Respiration is now a free passive ability instead of costing one genome.
b09fee7
to
5869f55
Compare
Pretty much done, but need to do something about the handling and acquirement of DNA (pretty much PolarisSS13/Polaris#1350 but with tweaks). |
|
||
msg_admin_attack("[key_name(user)] shocked [key_name(C)] with the [src].") | ||
|
||
visible_message("<span class='warning'>Arcs of electricity strike [C]!</span>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't electrocute_act() already produce log messages like these?
More then 30 days since progress made, closing this PR for now. |
Deleted? Any chance of this coming back? |
The commit history is all there, for cherry-picking from Polaris. |
I just had a go at fixing the merge conflicts. Got all of them I think except for icons/mob/head.dmi So just need to port PolarisSS13/Polaris#1350 or something? |
A variant of PolarisSS13/Polaris#1350 (as is, it needs tweaking for me to consider it any good), PolarisSS13/Polaris#1631, PolarisSS13/Polaris#1691, and PolarisSS13/Polaris#1792. |
Whatever, if it gets it working. |
Port of PolarisSS13/Polaris#161.
Port of PolarisSS13/Polaris#187.
Port of PolarisSS13/Polaris#277.
Port of PolarisSS13/Polaris#303.
Port of PolarisSS13/Polaris#585.
Port of PolarisSS13/Polaris#850.
Port of PolarisSS13/Polaris#859.
Port of PolarisSS13/Polaris#992.
Port of PolarisSS13/Polaris#1188.
Ports PolarisSS13/Polaris#1233.
May also require porting PolarisSS13/Polaris#609 and related PRs. Considering recent organ changes/edits I'm dreading this even more.