New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Antag ban fixes. #12783
Merged
Merged
Antag ban fixes. #12783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a syndicate ban. Makes sure all antag roles have a bantype var. Applying a syndicate ban now bans all roles rather than the old, hacky method. Removes checks for syndicate bans and replaces with checks for individual roles where applicable.
Do not merge, making changes and testing. |
…f respect AI bans.
Ready for review and merge. Tested working. |
👍 |
Needs a migration. |
Went over the changes. I think this should cover it?
|
PsiOmegaDelta
added a commit
to PsiOmegaDelta/Baystation12
that referenced
this pull request
Apr 28, 2016
Due to the changes in Baystation12#12783.
Merged
PsiOmegaDelta
added a commit
to PsiOmegaDelta/Baystation12
that referenced
this pull request
Apr 28, 2016
Due to the changes in Baystation12#12783.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12685.
Fixes banning for some antag roles applying a syndicate ban instead.
Fixes malf selecting players with AI bans.
Fixes some antag roles not showing up in the manual ban menu.
Makes sure all antag roles have a bantype var.Applying a syndicate ban now bans all roles rather than the old, hacky method.
Removes checks for syndicate bans and replaces with checks for individual roles where applicable.
Replaces bantype var with id datum.
Not tested.