Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban migration script. #12796

Merged
merged 1 commit into from Apr 28, 2016
Merged

Conversation

PsiOmegaDelta
Copy link
Member

Due to the changes in #12783.
New values are the corresponding strings for MODE_*.

Including all entries that were the same, albeit commented out, to visualize they were indeed checked.

@mloc
Copy link
Contributor

mloc commented Apr 28, 2016

the PM he sent me also had this: Additionally, all bantypes of Syndicate can be removed, because the syndicate ban has been reworked to simply individually banning all antag roles at once. Raptor says that because there aren't any regulars who are under syndicate bans, he isn't really worried about it.
not sure if that's something downstreams will appreciate though

@PsiOmegaDelta
Copy link
Member Author

PsiOmegaDelta commented Apr 28, 2016

To be honest I think I'd rather see that the Syndicate ban stays as its own thing, rather than it applying individual bans (but perhaps renamed to something more obvious).
As it, this means that applying a full antag/Syndicate ban creates 20 lines in the database and we have no real way to ensure people with a full antag ban are also banned from new antag types.

@mloc
Copy link
Contributor

mloc commented Apr 28, 2016

Sounds reasonable. 👍

@mustafakalash
Copy link
Contributor

Thanks for doing this.

@Raptor1628
Copy link
Contributor

To clarify, the lack of concern was about being banned from all antag positions, not the syndicate ban, I like having a button that bans someone from all antag positions regardless of how it works. What I was expressing was "no rush, there aren't that many people that are antag-banned that aren't also permabanned by now"

@comma comma merged commit 128efd5 into Baystation12:dev Apr 28, 2016
@PsiOmegaDelta PsiOmegaDelta deleted the 160428-BanMigration branch April 28, 2016 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants