-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BS12 posters #4277
BS12 posters #4277
Conversation
…spawn or just stay in their body for 30 minutes. Who does that? People that cause runtimes, that's who! (Jerks)
Fixes ZAS silliness with SoftDelete
Runtime fix for people that jump back in their body before hitting respawn
* Add dynamic loading of poster designs (untick group in DM to remove, no more toggles) * Fixes wirecutters duping posters * Fixes dropped posters not being placeable.
There are a LOT of references, here xD. |
Looks good to me. |
It would be nice if you made this a config option instead of a define in the codebase. |
What Ccomp5905 said. I would also like to see some of the references made less blatant, but otherwise it looks good to me. |
I took this from Cael's branch from two years ago without changing anything. Tell me which references you want to be changed and I'll do it one of the coming days. If you want a toggle, N3X1S has made a nice modular version of this code. |
desc += " This particular one depicts some sort of star in a grimace. The \"Don't Panic\" is written in big, friendly letters." | ||
if(11) | ||
name += " - Underwater Laboratory" | ||
desc += " This particular one is of the fabled last crew of Nanotrasen's previous project before going big on Asteroid mining, Sealab." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implies a causal link between Sea Lab and NT, could just change it to something generic about an undersea laboratory.
This code is N3X15's, with some tiny adjustments of mine. It should adress all your issues. |
Machine says it does not compile. |
PR contains the .int file 😦 |
/datum/poster/bay_29 | ||
icon_state="bsposter29" | ||
name = "Winter Is Coming" | ||
desc = "On the poster is a frighteningly large wolf, he warns: \"Only YOU can keep the station from freezing during planetary occultation!"\" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last part should be....
"Only YOU can keep the station from freezing during planetary occultation!""
You have to escape the first quote. That's what is giving your compile error.
Gives the choice of using poster based on /tg/ lore (clowns, greytide) or on bs12 lore (uh...).