Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BS12 posters #4277

Merged
merged 14 commits into from
Jan 15, 2014
Merged

BS12 posters #4277

merged 14 commits into from
Jan 15, 2014

Conversation

RKF45
Copy link
Contributor

@RKF45 RKF45 commented Jan 12, 2014

Gives the choice of using poster based on /tg/ lore (clowns, greytide) or on bs12 lore (uh...).

LightningIron and others added 11 commits January 9, 2014 11:37
…spawn or just stay in their body for 30 minutes.

Who does that?  People that cause runtimes, that's who!

(Jerks)
Runtime fix for people that jump back in their body before hitting respawn
* Add dynamic loading of poster designs (untick group in DM to remove, no more toggles)
* Fixes wirecutters duping posters
* Fixes dropped posters not being placeable.
@ghost
Copy link

ghost commented Jan 12, 2014

There are a LOT of references, here xD.

@MistakeNot4892
Copy link
Contributor

Looks good to me.

@Ccomp5950
Copy link
Contributor

It would be nice if you made this a config option instead of a define in the codebase.

@mloc mloc closed this Jan 12, 2014
@mloc mloc reopened this Jan 12, 2014
@ghost
Copy link

ghost commented Jan 12, 2014

What Ccomp5905 said. I would also like to see some of the references made less blatant, but otherwise it looks good to me.

@RKF45
Copy link
Contributor Author

RKF45 commented Jan 12, 2014

I took this from Cael's branch from two years ago without changing anything. Tell me which references you want to be changed and I'll do it one of the coming days. If you want a toggle, N3X1S has made a nice modular version of this code.

desc += " This particular one depicts some sort of star in a grimace. The \"Don't Panic\" is written in big, friendly letters."
if(11)
name += " - Underwater Laboratory"
desc += " This particular one is of the fabled last crew of Nanotrasen's previous project before going big on Asteroid mining, Sealab."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implies a causal link between Sea Lab and NT, could just change it to something generic about an undersea laboratory.

@RKF45
Copy link
Contributor Author

RKF45 commented Jan 13, 2014

This code is N3X15's, with some tiny adjustments of mine. It should adress all your issues.
I fail to see where the choice for bs12 posters are made, though.

@comma
Copy link
Contributor

comma commented Jan 14, 2014

Machine says it does not compile.
Also choice is made by tickig/unticking the file where those are defined.

@Ccomp5950
Copy link
Contributor

PR contains the .int file 😦

@Ccomp5950 Ccomp5950 closed this Jan 15, 2014
@Ccomp5950 Ccomp5950 reopened this Jan 15, 2014
/datum/poster/bay_29
icon_state="bsposter29"
name = "Winter Is Coming"
desc = "On the poster is a frighteningly large wolf, he warns: \"Only YOU can keep the station from freezing during planetary occultation!"\"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last part should be....

"Only YOU can keep the station from freezing during planetary occultation!""

You have to escape the first quote. That's what is giving your compile error.

@Ccomp5950 Ccomp5950 closed this Jan 15, 2014
@Ccomp5950 Ccomp5950 reopened this Jan 15, 2014
Ccomp5950 added a commit that referenced this pull request Jan 15, 2014
@Ccomp5950 Ccomp5950 merged commit dd7fef9 into Baystation12:dev Jan 15, 2014
@RKF45 RKF45 deleted the paint branch January 15, 2014 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants