-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airlock controller rewrite #4408
Conversation
imgz plz |
Should there be any safeguards on the "force door" buttons? Right now on the current controller you can force the doors while the airlock isn't cycling and both doors are closed. You can open both doors in one go if you want. Should the door controller have "force" buttons available? The advanced controller isn't used on the station anywhere yet, but I plan to use it in my engineering remap. |
Cannot be automatically merged, map is conflicting. Tried merging from the command line using mapmerge driver and still no go. |
Thought that might happen. I'll fix the map. |
- Fixed DP vent pumps not changing direction - Made airlock_sensor more versatile (and backwards compatible with old airlock code) - Added airlock_sensor and access_button airlock subtypes for easier mapping
- /datum/computer/file/embedded_program moved from embedded_controller_base.dm to code/game/machinery/embedded_controller/airlock_program.dm - embedded_controller_base.dm cleaned up and identical parts of the controller subtypes were moved here - embedded_controller subtypes moved to code/game/machinery/embedded_controller/airlock_controllers.dm - Added nanoUI templates for airlock controllers - Added a couple of classes to nano/css/shared.css for colouring buttons - Minor map update to maintain airlock compatibility and fix a broken airlock near virology
- Should now merge
Rebased and re applied the changes - this should now merge quite happily. |
Is this alright for a merge, Ccomp? |
Rewrote the airlock controller. It is now more versatile and has NanoUI.
More details in the commits.
Minor issue: air supply pipes are invisible in dream maker until you compile. They are still in the map, just not rendered. Not sure if this is an issue for anyone else.