Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile Errors on macOS #206

Closed
max5800 opened this issue Dec 11, 2023 · 4 comments
Closed

Compile Errors on macOS #206

max5800 opened this issue Dec 11, 2023 · 4 comments
Assignees
@lionkor
Labels
bug Something isn't working

Comments

@max5800
Copy link
Contributor

max5800 commented Dec 11, 2023

General information
OS:
macOS 14.1 (23B74) - Intel
BeamMP-Server Version:
3.1.3

Describe the bug
Cmake Build runs into errors.

To Reproduce
Steps to reproduce the behavior:

  1. 'brew install lua@5.3'
  2. Have CommandLine-Tools installed
  3. Run compile commands as documented in the readme.
  4. Get the following output:
    https://pastebin.com/5GeQ4f3d

Expected behavior
Get a Successful build.

Additional context
Could be an error on level 8, cause I have no idea what I'm doing.
@max5800 max5800 added the bug Something isn't working label Dec 11, 2023
@lionkor
Copy link
Member

lionkor commented Dec 11, 2023 •
edited
Loading

Hi, this is a bug in https://github.com/lionkor/commandline, I will fix it there and upstream the fix into here.

Thanks for reporting this. Would you be willing to help me test it once fixed?

@lionkor lionkor self-assigned this Dec 11, 2023
@max5800
Copy link
Contributor Author

max5800 commented Dec 12, 2023

Heyho,
thanks for the quick reply! I'm happy to help.
Just keep me updated when and what to test.
Danke!

@lionkor lionkor mentioned this issue Dec 12, 2023
Closed
@max5800 max5800 mentioned this issue May 18, 2024
Merged
@max5800
Copy link
Contributor Author

max5800 commented May 18, 2024 •
edited
Loading

@lionkor
I found two issues:

  1. The commandline module wants to have explicitly c++11 which is now added to the cmake file.
  2. Changed a line in TLuaEngine.cpp from ..nil to ..none

Related Pull Request 324

lionkor added a commit that referenced this issue May 19, 2024
@lionkor
Fix macos compile Issue (#324)
c880460 
Related [Issue 206](#206)
@max5800
Copy link
Contributor Author

max5800 commented May 20, 2024

pull request merged, fix implemented, will be in next release.
issue closed.

@max5800 max5800 closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lionkor lionkor

Labels
bug Something isn't working
Projects
Development
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lionkor @max5800