Update readme to new build system #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucky4Luuk
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Hey, this change seems pretty good to me, but there's a few notes I have:
- You have added build instructions, but the old build instructions still seem to be there. They are listed right underneath the runtime dependencies.
- The new build instructions don't list the requirements for building on Windows. I think this is worth writing down?
- In "Supported Operating Systems", it still links to the Prerequisites section, which is missing.
|
The points @Lucky4Luuk makes here are very good, Especially the steps for windows as that would be me :) |
|
Sorry @Lucky4Luuk if its not clear, but the windows build works the same. That was most of the point of this rewrite of the build system - ill fix the point about the old instructions. |
|
So @Starystars67 the same steps on windows, you just open the cmakelists with visual studio and it should just work |
Lucky4Luuk
approved these changes
Dec 9, 2023
Lucky4Luuk
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now building is like 2 steps, so the readme reflects that now.