Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI wallet - Invalid input for expiration_time parameter is not processed #422

Closed
jurijakimuk opened this issue Jan 29, 2019 · 1 comment
Closed

CLI wallet - Invalid input for expiration_time parameter is not processed #422

jurijakimuk opened this issue Jan 29, 2019 · 1 comment
Assignees
@jurijakimuk
Labels
cli Issues related to CLI Wallet task Something new to develop
Projects
Clear Cathode 3.1

Comments

@jurijakimuk
Copy link

Task description
When user provides an invalid input in as an "expiration_time" parameter, e.g. beam-wallet new_addr --expiration_time=i765giuy, then the operation succeeds. The expiration date for the new address is set to 24hr.

To Reproduce
Steps to reproduce the behaviour:
Preconditions: A cli wallet is set up and running.

  1. In cli run the command: beam-wallet new_addr --expiration_time=i765giuy.

Current behaviour
The user is asked for the password and after the password is provided - the operation succeeds. The expiration date for the new address is set to 24hr.

Expected behaviour
Not specified.
Suggestion:
The operation must not be possible if any of the parameters has invalid input. The user can, for example, get an error message, something like "Operation failed. Provided expiration_time is not valid."

Platform and build

  • Windows
  • 10 x64
  • 4323, master

Screenshot
process_error
@jurijakimuk jurijakimuk added task Something new to develop cli Issues related to CLI Wallet labels Jan 29, 2019
@jurijakimuk jurijakimuk added this to To Do in Backlog via automation Jan 29, 2019
@gingervik gingervik changed the title Invalid input for expiration_time parameter is not processed CLI wallet - Invalid input for expiration_time parameter is not processed Jan 31, 2019
@gingervik gingervik removed this from To Do in Backlog Jan 31, 2019
@gingervik gingervik added this to To do in Bright Boson 2.1 via automation Jan 31, 2019
@gingervik gingervik added this to To Do in Backlog via automation Mar 14, 2019
@gingervik gingervik removed this from To do in Bright Boson 2.1 Mar 14, 2019
@sasha-abramovich sasha-abramovich added this to To do in Bright Boson 2.2 via automation Mar 25, 2019
@sasha-abramovich sasha-abramovich removed this from To Do in Backlog Mar 25, 2019
@gingervik gingervik added this to To do in Clear Cathode 3.1 via automation May 2, 2019
@gingervik gingervik removed this from To do in Bright Boson 2.2 May 2, 2019
@Zeke133 Zeke133 self-assigned this Jul 11, 2019
@Zeke133 Zeke133 moved this from To do to In progress in Clear Cathode 3.1 Jul 11, 2019
Zeke133 added a commit that referenced this issue Jul 15, 2019
@Zeke133
#422 Address expiration parameters refactoring
f0753a0
@Zeke133 Zeke133 moved this from In progress to Done in Clear Cathode 3.1 Jul 15, 2019
@gingervik gingervik assigned gingervik and unassigned anatolse and Zeke133 Jul 23, 2019
@jurijakimuk jurijakimuk assigned jurijakimuk and unassigned gingervik Jul 23, 2019
@jurijakimuk
Copy link
Author

OK in 5648, master

Clear Cathode 3.1 automation moved this from Done to Tested Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jurijakimuk jurijakimuk

Labels
cli Issues related to CLI Wallet task Something new to develop
Projects
No open projects
Clear Cathode 3.1
  
Tested
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anatolse @gingervik @Zeke133 @jurijakimuk