Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom MigrationNode for build #234

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Allow custom MigrationNode for build #234

merged 2 commits into from
Apr 1, 2022

Conversation

amos402
Copy link
Contributor

@amos402 amos402 commented Mar 31, 2022

It's simple, MigrationNode.build uses hardcoded MigrationNode to create a node object, it forbid its subclasses to reuse this method.

@roman-right roman-right merged commit cdabb3c into BeanieODM:main Apr 1, 2022
@roman-right
Copy link
Member

Hey,

Thank you for the PR.
I send Beanie stickers to contributors. If you would like a few, please share your postal address in DM (email or discord)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amos402 @roman-right