Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add 950 tone to colors #478

Merged
merged 2 commits into from
May 31, 2024
Merged

Fix: Add 950 tone to colors #478

merged 2 commits into from
May 31, 2024

Conversation

ntatoud
Copy link
Contributor

@ntatoud ntatoud commented May 22, 2024

Describe your changes

closes #477

Added the 950 tone to all tailwind colors and updated the storybook color guideline by adding this new tone.

Screenshots

image

Checklist

  • I performed a self review of my code
  • I ensured that everything is written in English
  • I tested the feature or fix on my local environment
  • I ran the pnpm storybook command and everything is working

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
start-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 11:04am

Copy link
Member

@ivan-dalmet ivan-dalmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you match the colors to the "new" tailwind colors names?

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntatoud ntatoud merged commit 3e6493e into master May 31, 2024
7 checks passed
@ntatoud ntatoud deleted the fix/missing-color-tone branch May 31, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing 950 color tone in tailwindColors and styleguide
3 participants