This repository has been archived by the owner on Aug 15, 2022. It is now read-only.
Changed the network object registration timing #270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why pushed this PR?
I had a problem that the client A doesn't get synced a network object of the client B sometimes when they try to connect to a server at the same time.
Sequences when new client connects to a server(AFAIK):
In the case that two clients try to connect at the same time,
sometimes the client connected later than another doesn't get the networkObject data for another client.
There are two clients: A, B.
A3-B1-B2-A4 => a networkObject of the client A doesn't get synced on the client B side, because A4 happens later than B2.
so, to solve these problem, I merged the step 3 and 4 in to one step.
Merged Sequences:
so, A3-B1-B2 (NetworkObjects is updated at A3 timing, there's no omitted data at B2.)
Please, review this PR and give me any opinons to discuss or questions about this.